[PATCH] Re: This Week on perl5-porters - 20-26 October 2008

["Jerry D. Hedden" <jdhedden@cpan.org>]

> This Week on perl5-porters - 20-26 October 2008
...
> Patches of Interest
>
> Revert const'ing in cygwin.c
>
> Changes to blead and backports to 5.10 left some consting problems
> that caused the compiler to grumble a bit. This patch was to clean up
> the warnings on 5.10, and appears to be Warnocked.

Is this on your TODO list, Nick?

http://www.nntp.perl.org/group/perl.perl5.porters/2008/10/msg140827.html

(I attached the patch again for your convenience.)
--- perl/cygwin/cygwin.c
+++ perl/cygwin/cygwin.c
@@ -83,8 +83,7 @@
 do_spawn (char *cmd)
 {
     dTHX;
-    char const **a;
-    char *s,*metachars = "$&*(){}[]'\";\\?>|<~`\n";
+    char **a,*s,*metachars = "$&*(){}[]'\";\\?>|<~`\n";
     const char *command[4];
 
     while (*cmd && isSPACE(*cmd))
@@ -122,7 +121,7 @@
 	    return do_spawnvp("sh",command);
 	}
 
-    Newx (PL_Argv,(s-cmd)/2+2,const char*);
+    Newx (PL_Argv,(s-cmd)/2+2,char*);
     PL_Cmd=savepvn (cmd,s-cmd);
     a=PL_Argv;
     for (s=PL_Cmd; *s;) {

---

Follow-Ups from:

Nicholas Clark <nick@ccl4.org>

---

[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index][Thread Index][Top&Search][Original]

---