Re: [PATCH?] $ENV{TEST_JOBS} vs $ENV{HARNESS_OPTIONS}

["Rafael Garcia-Suarez" <rgarciasuarez@gmail.com>]

2008/8/12 Bram <p5p@perl.wizbit.be>:
> The problem comes from
> http://public.activestate.com/cgi-bin/perlbrowse/f/lib/Module/Build/Base.pm
> that uses Test::Harness.
>
> What happens is:
>
> - If $ENV{TEST_JOBS} is unset: Test::Harness is used which does a local
> $ENV{HARNESS_OPTIONS} which unsets it.
>
> - If $ENV{TEST_JOBS} is set: TAP::Harness is used which leaves
> $ENV{HARNESS_OPTIONS} alone. This causes the options to leak into some of
> the test that require Test::Harness which causes failures because it starts
> running all the test in parallel instead of sequence.
>
> The solution is to add the local $ENV{HARNESS_OPTIONS} in t/harness (or
> maybe in TAP::Harness).
>
>
> Test::Smoke currently only allows the setting of HARNESS_OPTIONS.
> Some smoke config already use this feature to set HARNESS_OPTIONS to j5.
> To allow those config to use the proper parallel testing method the parsing
> of $ENV{HARNESS_OPTIONS} (added in my previous patch) is needed.
>
> (If the smoke configuration changes then the parsing can be removed.)
>
>
> IMHO it would be best to apply the patch until Test::Smoke changes (if it
> changes).

OK. Thanks, applied as #34314.

---

[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index][Thread Index][Top&Search][Original]

---