[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index][Thread Index][Top&Search][Original]

Re: [perl #36673] sub foo(@$) {} should generate an error

From: "Rafael Garcia-Suarez" <rgarciasuarez@gmail.com>
To: renee.baecker@smart-websolutions.de
Cc: perlbug-followup@perl.org, "Perl5 Porters" <perl5-porters@perl.org>
Date: Sun, 8 Jun 2008 10:58:26 +0200
Message-ID: <b77c1dce0806080158p75802c76x43641933c0d9b85@mail.gmail.com>

2008/5/26 Renée Bäcker <renee.baecker@smart-websolutions.de>:
> I've revised the patch. Now the warning applies to %, too. And it checks if
> _ is used before the ;.

Thanks, applied as #34021, with a few changes :

I changed the test to go in t/lib/warnings/toke instead of
t/comp/proto.t. I think that warnings tests from proto.t should be
moved to t/lib/warnings/toke too. Want to try it ?:)

Also, your patch was incorrectly emitting warnings even when warnings
were off. I fixed that.

Follow-Ups from:: Renée Bäcker <renee.baecker@smart-websolutions.de>
"Rafael Garcia-Suarez" <rgarciasuarez@gmail.com>

[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index][Thread Index][Top&Search][Original]