[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index][Thread Index][Top&Search][Original]

[PATCH] perlbug prose patch (and some evals, too)



This morning, clkao pinged me and mentioned that he couldn't get  
perlbug to set the From: header when sending a bug report.  I promised  
him I'd take a look.

I opened up perlbug determined to add one line and send a patch.  
Somehow, I never got around to adding the line CL asked for as I got  
distracted by the prose of the tool.

Attached is a patch which rewrites most of the text (both within the  
tool and in the POD). It also replaced a couple of string evals with  
block evals, though that could be extracted to a separate patch if  
needed.

If this patch is accepted, next on my hitlist is the prompting  
infrastructure and some other refactoring that really, really ought to  
happen.

I know there's a strong preference not to reformat code in the core,  
but perlbug could really use it.  Would a perltidying be accepted?  
Either before or after a larger refactoring?

As everyone else on #p5p had the good sense to be off enjoying their  
Saturday afternoon, I didn't manage to figure out the right way to  
supply a patch to a .PL file in the utils/ directory, so this patch  
was written to apply to an extracted copy of the perlbug utility  
(though it applies cleanly to perlbug.PL.)  What's the _right_ way to  
patch such things?


  perlbug |  440 ++++++++++++++++++++++++++++++++++ 
+-----------------------------
  1 file changed, 243 insertions(+), 197 deletions(-)

perlbug.prose.patch




Best,
Jesse

PS clkao: I promise to fix your bug. It just didn't happen today

This is a digitally signed message part


Follow-Ups from:
Ronald J Kimball <rjk-perl-p5p@tamias.net>
"Craig A. Berry" <craig.a.berry@gmail.com>

[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index][Thread Index][Top&Search][Original]